Merged
Conversation
Collaborator
benc-uk
commented
May 14, 2025
benc-uk
commented
- Remove old nginx conf
- Refreshed for eslint and all packages to latest
- Fix run target dependency to ensure frontend modules are available before starting processes
…fore starting processes
…provider configuration
… linting commands
…mprove test command
…ove test reporting, and enhance test commands
…t reporting, and improve integration test command
…consistency and install additional Go tools
…roper configuration
…prove output directory management
…n tests and adjust Makefile for process management
…PI integration tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refreshes the project configuration and dependencies for 2025, removes the old nginx configuration, and updates package versions and run target dependencies. Key changes include new API endpoint test files for products, orders, and cart; updates to documentation and Makefile targets; and revisions to CI/CD workflows and linting configurations.
Reviewed Changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| api/bruno/Dapr Store API//.bru | New API test definition files for products, orders, and cart |
| api/api-tests.http & api/api-reference.http | Added/updated API test and reference files for httpYac |
| README.md | Updated documentation and project status details |
| Makefile | Updated build, test targets, and run commands; added clear-state flag |
| .golangci.yaml | Revised linting configuration and settings |
| .github/workflows/release-images.yml | Upgraded checkout action version |
| .github/workflows/ci-build.yml | Updated CI build workflow with new Go version, testing, and reporting |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refreshes dependencies, tooling, and CI, and adds comprehensive API integration tests.
- Updates linting, testing, and build targets (Makefile, .golangci.yaml)
- Introduces Dapr Store API test specs (.bru) and httpYac tests (api/api-tests.http)
- Bumps GitHub Action versions and enhances CI to run unit + API tests with reports
Reviewed Changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Added test-report, test-api, clear-state, api-spec targets; bumped version |
| api/bruno/Dapr Store API/**/*.bru | New Dapr HTTP test specs for Products, Orders, Cart |
| api/api-tests.http | Added httpYac integration tests |
| .github/workflows/ci-build.yml | Updated actions/setup-go, checkout versions, added API test step |
| .golangci.yaml | Refreshed linter config and enabled additional linters |
| README.md | Updated docs to reflect new commands and versions |
Comments suppressed due to low confidence (4)
Makefile:20
- New targets (
test-report,test-api,test-api-report,clear-state,api-spec) are not listed in .PHONY; consider adding them to ensure make treats them properly.
.PHONY: help lint lint-fix test test-reports docker-build docker-run docker-stop docker-push bundle clean run stop
api/bruno/Dapr Store API/Cart/Submit.bru:26
- The status literal new is unquoted. It should be compared as a string, e.g., eq "new" to ensure the test matcher works correctly.
res.body.status: eq new
api/bruno/Dapr Store API/Products/Get Single Product.bru:15
- The ID literal prd003 is unquoted. It should be compared as a string, e.g., eq "prd003" so the assertion matches correctly.
res.body.id: eq prd003
api/bruno/Dapr Store API/Products/Search Products.bru:15
- The string literal Paisley is unquoted; wrap it in quotes (e.g., contains "Paisley") to ensure the test assertion treats it as a string.
res.body[0].name: contains Paisley
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.